Messages in this thread | | | Date | Wed, 15 Jan 2014 09:11:49 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH v6 3/8] x86: add generic function to modify more calls using int3 framework |
| |
On Wed, 15 Jan 2014 17:18:01 +0900 Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> >> +static char bp_int3; > > > > bp_int3 is not going to be anything but 0xcc. Let's change that to: > > > > static char bp_int3 = 0xcc; > > > > And remove the other initializations. > > just a comment. > If it is always 0xcc, it should be a const variable. >
Yeah, I was thinking that too. As long as sizeof(bp_int3) still works, which it should for just adding a "const", and not make it a macro.
static const bp_int3 = 0xcc;
Thanks!
-- Steve
| |