Messages in this thread | | | Date | Wed, 15 Jan 2014 15:05:14 +0100 | From | Peter Zijlstra <> | Subject | Re: [BUG] [ tip/sched/core ] System unresponsive after booting |
| |
On Wed, Jan 15, 2014 at 12:00:18PM +0100, Peter Zijlstra wrote: > On Wed, Jan 15, 2014 at 10:22:45AM +0100, Ingo Molnar wrote: > > 2) > > > > It's not clear why this change to __setscheduler() was done: > > > > /* > > * Allow unprivileged RT tasks to decrease priority: > > */ > > if (user && !capable(CAP_SYS_NICE)) { > > + if (fair_policy(policy)) { > > + if (!can_nice(p, attr->sched_nice)) > > + return -EPERM; > > + } > > + > > if (rt_policy(policy)) {o > > Bah, I'm pretty sure I wrote that :/ And I can't for the life of me > remember why I did that. Complete fail there.
Ah, I remember, its because we can now set nice through this path as well, so we have to do permission checks.
The existing 'nice' syscalls have their own permission checks and do not user __sched_setscheduler() at all.
| |