Messages in this thread | | | Date | Wed, 15 Jan 2014 10:28:13 +0100 | Subject | Re: [PATCH 7/7] drivers/gpio: don't check resource with devm_ioremap_resource | From | Linus Walleij <> |
| |
On Tue, Jan 14, 2014 at 12:58 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > --- > > Should go via subsystem tree > > drivers/gpio/gpio-davinci.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index 84be701..a5e1a56 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -172,11 +172,6 @@ static int davinci_gpio_probe(struct platform_device *pdev) > } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(dev, "Invalid memory resource\n"); > - return -EBUSY; > - } > - > gpio_base = devm_ioremap_resource(dev, res); > if (IS_ERR(gpio_base)) > return PTR_ERR(gpio_base);
Acked-by: Linus Walleij <linus.walleij@linaro.org>
The DaVinci maintainers are queuing GPIO patches for their driver for this merge window, so requesting them to apply this patch.
Yours, Linus Walleij
| |