Messages in this thread | | | Date | Wed, 15 Jan 2014 09:18:05 +0800 | From | Ying Xue <> | Subject | Re: [PATCH net-next 10/10] net: nl80211: __dev_get_by_index instead of dev_get_by_index to find interface |
| |
On 01/14/2014 08:11 PM, Johannes Berg wrote: > On Tue, 2014-01-14 at 15:41 +0800, Ying Xue wrote: > >> @@ -2218,10 +2194,6 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info) >> rdev->wiphy.coverage_class = old_coverage_class; >> } >> } >> - >> - bad_res: >> - if (netdev) >> - dev_put(netdev); >> return result; > > I believe that could be "return 0;" now, which would make the code > easier to read. >
Yes, I will change it in next version.
Thanks, Ying
> johannes > > >
| |