lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] i810: delete useless variable
On 2014-01-13 18:17, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Delete a variable that is at most only assigned to a constant, but never
> used otherwise.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> constant c;
> @@
>
> -T i;
> <... when != i
> -i = c;
> ...>
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/video/i810/i810_main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c
> index 038192a..bb674e4 100644
> --- a/drivers/video/i810/i810_main.c
> +++ b/drivers/video/i810/i810_main.c
> @@ -2011,9 +2011,7 @@ static int i810fb_init_pci(struct pci_dev *dev,
> struct fb_info *info;
> struct i810fb_par *par = NULL;
> struct fb_videomode mode;
> - int i, err = -1, vfreq, hfreq, pixclock;
> -
> - i = 0;
> + int err = -1, vfreq, hfreq, pixclock;
>
> info = framebuffer_alloc(sizeof(struct i810fb_par), &dev->dev);
> if (!info)
>

Thanks, queued for 3.14.

Tomi


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-01-14 09:41    [W:1.184 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site