lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data
Date

> > Whether the dt is used or not, almost all the simple card information
> > for the DAI link and sound card are initialized in the simple card driver.
> >
> > And for the platform caller, the snd_link and snd_card are of no use, so
> > move them from struct asoc_simple_card_info to struct asoc_simple_card_data.
> >
> > And now only one DAI link is supported for simple card.
> >
> > Suggested-by: Jean-Francois Moine <moinejf@free.fr>
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > ---
>
> This patch seems have many this kind of lines
> - info->xxx
> + sdata->info->xxx
>
> But, how about add this line to each function ?
>
> struct asoc_simple_card_info *info = &sdata->info;
>
> Patch will be more readable
>

Yes, that's looks perfect.

See the next version please.

Thanks,

--
Best Regards,
Xiubo




\
 
 \ /
  Last update: 2014-01-14 09:41    [W:0.031 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site