lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] hotplug, memory: move register_memory_resource out of the lock_memory_hotplug
On Tue, 14 Jan 2014, Nathan Zimmer wrote:

> We don't need to do register_memory_resource() since it has its own lock and
> doesn't make any callbacks.
>

We need to do it, just not under lock_memory_hotplug() :).

> Also register_memory_resource return NULL on failure so we don't have anything
> to cleanup at this point.
>
>
> The reason for this rfc is I was doing some experiments with hotplugging of
> memory on some of our larger systems. While it seems to work, it can be quite
> slow. With some preliminary digging I found that lock_memory_hotplug is
> clearly ripe for breakup.
>
> It could be broken up per nid or something but it also covers the
> online_page_callback. The online_page_callback shouldn't be very hard to break
> out.
>
> Also there is the issue of various structures(wmarks come to mind) that are
> only updated under the lock_memory_hotplug that would need to be dealt with.
>
>
> cc: Andrew Morton <akpm@linux-foundation.org>
> cc: Tang Chen <tangchen@cn.fujitsu.com>
> cc: Wen Congyang <wency@cn.fujitsu.com>
> cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> cc: Hedi <hedi@sgi.com>
> cc: Mike Travis <travis@sgi.com>
> cc: linux-mm@kvack.org
> cc: linux-kernel@vger.kernel.org

Looks like you're modifying a pre-3.12 kernel version that doesn't have
27356f54c8c3 ("mm/hotplug: verify hotplug memory range").

When your patch is signed off, feel free to add

Acked-by: David Rientjes <rientjes@google.com>


\
 
 \ /
  Last update: 2014-01-15 02:21    [W:0.045 / U:1.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site