lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [slub] WARNING: CPU: 0 PID: 0 at mm/slub.c:1511 __kmem_cache_create()
On Tue, 14 Jan 2014, Dave Hansen wrote:

> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c65c1877bd6826ce0d9713d76e30a7bed8e49f38
>
> I think the assert is just bogus at least in the early case.
> early_kmem_cache_node_alloc() says:
> * No kmalloc_node yet so do it by hand. We know that this is the first
> * slab on the node for this slabcache. There are no concurrent accesses
> * possible.
>
> Should we do something like the attached patch? (very lightly tested)
>

Yeah, I think that's the best option to keep the runtime checking to
ensure the proper lock is held on debug kernels with lockdep enabled and
is better than reverting back to the comment.


\
 
 \ /
  Last update: 2014-01-15 02:01    [W:0.029 / U:1.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site