Messages in this thread | | | Date | Tue, 14 Jan 2014 14:31:33 -0800 (PST) | Subject | Re: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer | From | David Miller <> |
| |
From: Haiyang Zhang <haiyangz@microsoft.com> Date: Thu, 9 Jan 2014 14:24:47 -0800
> This will allow us to use bigger receive buffer, and prevent allocation failure > due to fragmented memory. > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Not until you start using paged SKBs in netvsc_recv_callback.
Whatever fragmention you think you're avoiding in the hyperv layer, you're still going to get from the:
skb = netdev_alloc_skb_ip_align(net, packet->total_data_buflen);
call there.
This change makes no sense in isolation, therefore I'm not applying it until you also include the appropriate changes to avoid the same exact fragmentation issue in netvsc_drv.c as stated above.
| |