Messages in this thread | | | Date | Tue, 14 Jan 2014 08:47:52 +0200 | From | Jack Morgenstein <> | Subject | Re: [PATCH 1/2] net/mlx4_core: clean up cq_res_start_move_to() |
| |
This time, replying to the list as well.
-Jack P.S. sorry for the delay, I was swamped.
On Tue, 07 Jan 2014 14:01:18 +0100 Paul Bolle <pebolle@tiscali.nl> wrote:
> + } else { > + /* state == RES_CQ_HW */ > + if (r->com.state != RES_CQ_ALLOCATED)
if (state != RES_CQ_HW || r->com.state != RES_CQ_ALLOCATED) to protect against any bad calls to this function (although I know that currently there are none).
This also preserves the behavior of the switch statement.
> err = -EINVAL; > - } > + else > + err = 0; > + } > > - if (!err) { > - r->com.from_state = r->com.state; > - r->com.to_state = state; > - r->com.state = RES_CQ_BUSY; > - if (cq) > - *cq = r; > - } > + if (!err) { > + r->com.from_state = r->com.state; > + r->com.to_state = state; > + r->com.state = RES_CQ_BUSY;
Please keep the "if" here. Protects against (future) bad calls.
> + *cq = r; > }
| |