Messages in this thread | | | Date | Tue, 14 Jan 2014 12:02:41 +0000 | From | Ben Dooks <> | Subject | Re: [PATCH 2/3] power: clock_ops.c: check return of clk_enable() in pm_clk_resume() |
| |
On 13/01/14 19:55, Rafael J. Wysocki wrote: > On Saturday, January 11, 2014 01:05:39 PM Ben Dooks wrote:
>> @@ -262,8 +263,9 @@ int pm_clk_resume(struct device *dev) >> >> list_for_each_entry(ce, &psd->clock_list, node) { >> if (ce->status < PCE_STATUS_ERROR) { >> - clk_enable(ce->clk); >> - ce->status = PCE_STATUS_ENABLED; >> + ret = clk_enable(ce->clk); >> + if (ret == 0) > > Can you please use if (!ret) here? > > And analogously in patch [3/3]?
I will fix and re-send today, thanks.
-- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
| |