lkml.org 
[lkml]   [2014]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] power: clock_ops.c: check return of clk_enable() in pm_clk_resume()
    On 13/01/14 19:55, Rafael J. Wysocki wrote:
    > On Saturday, January 11, 2014 01:05:39 PM Ben Dooks wrote:

    >> @@ -262,8 +263,9 @@ int pm_clk_resume(struct device *dev)
    >>
    >> list_for_each_entry(ce, &psd->clock_list, node) {
    >> if (ce->status < PCE_STATUS_ERROR) {
    >> - clk_enable(ce->clk);
    >> - ce->status = PCE_STATUS_ENABLED;
    >> + ret = clk_enable(ce->clk);
    >> + if (ret == 0)
    >
    > Can you please use if (!ret) here?
    >
    > And analogously in patch [3/3]?

    I will fix and re-send today, thanks.


    --
    Ben Dooks http://www.codethink.co.uk/
    Senior Engineer Codethink - Providing Genius


    \
     
     \ /
      Last update: 2014-01-14 14:01    [W:3.008 / U:0.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site