Messages in this thread Patch in this message | | | Date | Mon, 13 Jan 2014 15:52:05 -0800 | From | Greg KH <> | Subject | Re: [PATCH] staging: comedi: das1800: Fixing foo * bar should be foo *bar |
| |
On Mon, Jan 13, 2014 at 11:19:15PM +0000, Joe Borg wrote: > Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo > *bar' in the parameters of function munge_data(). > > Signed-off-by: Joe Borg <cyborg101010@gmail.com> > --- > drivers/staging/comedi/drivers/das1800.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c > index 1880038..8fb87df 100644 > --- a/drivers/staging/comedi/drivers/das1800.c > +++ b/drivers/staging/comedi/drivers/das1800.c > @@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev, > return sample; > } > > -static void munge_data(struct comedi_device *dev, uint16_t * array, > +static void munge_data(struct comedi_device *dev, uint16_t *array, > unsigned int num_elements)
Ok, after all that work, it turns out I can't even apply this patch as someone else did it already a while ago. You should be working off of linux-next, or my staging.git tree, not Linus's tree, as that does not contain all of the work we are doing on the next version of linux (hence the -next).
So, care to try again with a different fix?
thanks,
greg k-h
| |