Messages in this thread | | | Date | Tue, 14 Jan 2014 00:43:14 +0100 | From | Alexandre Belloni <> | Subject | Re: [PATCH 2/3] iio: mxs-lradc: fix invalid channel number detection |
| |
On 13/01/2014 21:25, Marek Vasut wrote: > On Monday, January 13, 2014 at 05:02:02 PM, Alexandre Belloni wrote: >> 16 would be accepted as a channel number but it is invalid. It doesn't >> really have any effect as mxs_lradc_read_raw is called from a "controlled" >> environment so it it only gets values going from 0 to 15. >> >> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > Why don't you remove the check entirely then ? >
I'm not quite sure the inkernel API is sanitizing the input correctly but maybe I didn't check enough. Maybe Jonathan can comment ?
-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |