Messages in this thread | | | Date | Tue, 14 Jan 2014 00:07:40 +0100 | From | Olaf Hering <> | Subject | Re: [PATCH] xen-blkfront: remove type check from blkfront_setup_discard |
| |
On Mon, Jan 13, Boris Ostrovsky wrote:
> On 01/13/2014 04:30 AM, Olaf Hering wrote: > >>Similarly, if xenbug_gather("discard-secure") fails, I think the code will > >>assume that secure discard has not been requested. I don't know what > >>security implications this will have but it sounds bad to me. > >There are no security implications, if the backend does not advertise it > >then its not present. > > Right. But my questions was what if the backend does advertise it and wants > the frontent to use it but xenbus_gather() in the frontend fails. Do we want > to silently continue without discard-secure? Is this safe?
The frontend can not know that the backend advertised discard-secure because the frontend just failed to read the property which indicates discard-secure should be enabled.
Olaf
| |