lkml.org 
[lkml]   [2014]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] qlcnic: Convert vmalloc/memset to kcalloc
From
From: Joe Perches <joe@perches.com>
Date: Wed, 08 Jan 2014 22:42:25 -0800

> vmalloc is a limited resource. Don't use it unnecessarily.
>
> It seems this allocation should work with kcalloc.
>
> Remove unnecessary memset(,0,) of buf as it's completely
> overwritten as the previously only unset field in
> struct qlcnic_pci_func_cfg is now set to 0.
>
> Use kfree instead of vfree.
> Use ETH_ALEN instead of 6.
>
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks Joe.


\
 
 \ /
  Last update: 2014-01-13 21:01    [W:0.770 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site