Messages in this thread | | | Date | Mon, 13 Jan 2014 11:17:50 -0800 (PST) | Subject | Re: [PATCH net-next] qlcnic: Convert vmalloc/memset to kcalloc | From | David Miller <> |
| |
From: Joe Perches <joe@perches.com> Date: Wed, 08 Jan 2014 22:42:25 -0800
> vmalloc is a limited resource. Don't use it unnecessarily. > > It seems this allocation should work with kcalloc. > > Remove unnecessary memset(,0,) of buf as it's completely > overwritten as the previously only unset field in > struct qlcnic_pci_func_cfg is now set to 0. > > Use kfree instead of vfree. > Use ETH_ALEN instead of 6. > > Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
| |