lkml.org 
[lkml]   [2014]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 077/208] mm/compaction: respect ignore_skip_hint in update_pageblock_skip
    Date
    3.11.10.3 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Joonsoo Kim <iamjoonsoo.kim@lge.com>

    commit 6815bf3f233e0b10c99a758497d5d236063b010b upstream.

    update_pageblock_skip() only fits to compaction which tries to isolate
    by pageblock unit. If isolate_migratepages_range() is called by CMA, it
    try to isolate regardless of pageblock unit and it don't reference
    get_pageblock_skip() by ignore_skip_hint. We should also respect it on
    update_pageblock_skip() to prevent from setting the wrong information.

    Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Acked-by: Vlastimil Babka <vbabka@suse.cz>
    Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
    Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Rafael Aquini <aquini@redhat.com>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Cc: Wanpeng Li <liwanp@linux.vnet.ibm.com>
    Cc: Mel Gorman <mgorman@suse.de>
    Cc: Rik van Riel <riel@redhat.com>
    Cc: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    mm/compaction.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/mm/compaction.c b/mm/compaction.c
    index 05ccb4c..9a3e351 100644
    --- a/mm/compaction.c
    +++ b/mm/compaction.c
    @@ -134,6 +134,10 @@ static void update_pageblock_skip(struct compact_control *cc,
    bool migrate_scanner)
    {
    struct zone *zone = cc->zone;
    +
    + if (cc->ignore_skip_hint)
    + return;
    +
    if (!page)
    return;

    --
    1.8.3.2


    \
     
     \ /
      Last update: 2014-01-13 20:41    [W:3.095 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site