Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 10/28] perf report: Cache cumulative callchains | Date | Mon, 13 Jan 2014 17:45:45 +0900 |
| |
Hi Jiri,
On Sat, 11 Jan 2014 17:02:54 +0100, Jiri Olsa wrote: > On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: >> It is possble that a callchain has cycles or recursive calls. In that >> case it'll end up having entries more than 100% overhead in the >> output. In order to prevent such entries, cache each callchain node >> and skip if same entry already cumulated.
[SNIP] >> + node = callchain_cursor_current(&callchain_cursor); >> + if (node == NULL) >> + return 0; > > some leftover? looks like nop..
Ah, right. I'll get rid of it.
Thanks, Namhyung
| |