lkml.org 
[lkml]   [2014]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 10/28] perf report: Cache cumulative callchains
Date
Hi Jiri,

On Sat, 11 Jan 2014 17:02:54 +0100, Jiri Olsa wrote:
> On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote:
>> It is possble that a callchain has cycles or recursive calls. In that
>> case it'll end up having entries more than 100% overhead in the
>> output. In order to prevent such entries, cache each callchain node
>> and skip if same entry already cumulated.

[SNIP]
>> + node = callchain_cursor_current(&callchain_cursor);
>> + if (node == NULL)
>> + return 0;
>
> some leftover? looks like nop..

Ah, right. I'll get rid of it.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2014-01-13 10:41    [W:0.113 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site