Messages in this thread | | | Date | Mon, 13 Jan 2014 10:03:40 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH] pinctrl: tegra1x4: initialize at arch_initcall time |
| |
On 01/13/2014 02:02 AM, Thierry Reding wrote: > On Fri, Jan 10, 2014 at 04:50:16PM -0800, Andrew Bresticker wrote: >> Many devices rely on pinctrl/pinmux settings being applied >> before probing and some of these may probe before device_initcall >> time (e.g. i2c at subsys_initcall). Move Tegra1x4 pinctrl driver >> registration to arch_initcall time so that proper pin settings >> can be applied earlier. >> >> Signed-off-by: Andrew Bresticker <abrestic@chromium.org> >> --- >> drivers/pinctrl/pinctrl-tegra114.c | 13 ++++++++++++- >> drivers/pinctrl/pinctrl-tegra124.c | 13 ++++++++++++- >> 2 files changed, 24 insertions(+), 2 deletions(-) > > I wonder if a better approach would be to add pin control and pin mux > settings for devices that explicitly need them to the device tree nodes > of the devices themselves.
We can't do that; the entire pinctrl state needs to be programmed at once to avoid the conflict of multiple pins/groups being muxed to the same function. However, we can make this work with empty states I believe.
| |