Messages in this thread Patch in this message | | | Date | Mon, 13 Jan 2014 07:55:39 -0800 | From | tip-bot for Daniel Lezcano <> | Subject | [tip:sched/core] sched: Reduce nohz_kick_needed() parameters |
| |
Commit-ID: 4a725627f21df6b280a19f50bc849daaab3b1544 Gitweb: http://git.kernel.org/tip/4a725627f21df6b280a19f50bc849daaab3b1544 Author: Daniel Lezcano <daniel.lezcano@linaro.org> AuthorDate: Mon, 6 Jan 2014 12:34:39 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Mon, 13 Jan 2014 13:47:27 +0100
sched: Reduce nohz_kick_needed() parameters
The cpu information is already stored in the struct rq, so no need to pass it as parameter to the nohz_kick_needed function.
The caller of this function just called idle_cpu() before to fill the rq->idle_balance field.
Use rq->cpu and rq->idle_balance.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1389008085-9069-3-git-send-email-daniel.lezcano@linaro.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/sched/fair.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b35d322..c47b1ce 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6788,14 +6788,14 @@ end: * - For SD_ASYM_PACKING, if the lower numbered cpu's in the scheduler * domain span are idle. */ -static inline int nohz_kick_needed(struct rq *rq, int cpu) +static inline int nohz_kick_needed(struct rq *rq) { unsigned long now = jiffies; struct sched_domain *sd; struct sched_group_power *sgp; - int nr_busy; + int nr_busy, cpu = rq->cpu; - if (unlikely(idle_cpu(cpu))) + if (unlikely(rq->idle_balance)) return 0; /* @@ -6885,7 +6885,7 @@ void trigger_load_balance(struct rq *rq) likely(!on_null_domain(cpu))) raise_softirq(SCHED_SOFTIRQ); #ifdef CONFIG_NO_HZ_COMMON - if (nohz_kick_needed(rq, cpu) && likely(!on_null_domain(cpu))) + if (nohz_kick_needed(rq) && likely(!on_null_domain(cpu))) nohz_balancer_kick(cpu); #endif }
| |