lkml.org 
[lkml]   [2014]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3
On Sat, 11 Jan 2014 18:26:02 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> > div = 148500 / mode->clock;
> > + if (div != 0) {
> > + div--;
> > + if (div > 3)
> > + div = 3;
> > + }
>
> As the driver currently stands, we know that the clock divider works for
> the lower resolution modes. So, as things stand, for 74.25MHz modes,
> we get a divisor of one.
>
> Your patch changes this, the divider becomes zero. I wonder whether
> you've tested 720p modes at all with this?

In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode
works fine.

--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-01-13 17:21    [W:0.040 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site