Messages in this thread | | | Date | Mon, 13 Jan 2014 21:54:33 +0800 | From | Bruce Liu <> | Subject | Re: [PATCH 1/1] When timestamping is enabled, stmmac_tx_clean will call stmmac_get_tx_hwtstamp to get tx TS. It's possible that skb is NULL because there are other network frames that use several descriptors. So we must return immediately in stmmac_get_t |
| |
On Sun, Jan 12, 2014 at 12:38:28PM +0100, Daniel Borkmann wrote: > On 01/12/2014 10:39 AM, Bruce Liu wrote: > > When timestamping is enabled, stmmac_tx_clean will call stmmac_get_tx_hwtstamp to get tx TS. > > It's possible that skb is NULL because there are other network frames that use several descriptors. > > So we must return immediately in stmmac_get_tx_hwtstamp if skb is NULL to avoid system crash. > > > > > >Signed-off-by: Bruce Liu <damuzi000@gmail.com> > > Please see Documentation/SubmittingPatches +489 > > You subject line is way too long and should just be something like: > > [PATCH net-next] net: stmmac: fix NULL pointer dereference in stmmac_get_tx_hwtstamp > > Don't indent your actual commit message with whitespaces as prefix, > and do a line break after around 70 chars. > > Btw, I mentioned net-next in the subject since merge window will > open soon anyway. >
Thanks, and I'll resend the patch.
Bruce.
| |