Messages in this thread | | | Date | Mon, 13 Jan 2014 12:34:23 +0000 | From | "Jan Beulich" <> | Subject | Re: [Xen-devel] [PATCH v2] xen-blkfront: remove type check from blkfront_setup_discard |
| |
>>> On 13.01.14 at 13:01, Olaf Hering <olaf@aepfle.de> wrote: > On Mon, Jan 13, Jan Beulich wrote: > >> You can't do this in one go - the first two and the last one may be >> set independently (and are independent in their meaning), and >> hence need to be queried independently (xenbus_gather() fails >> on the first absent value). > > Yes, thats the purpose. Since the properties are required its an all or > nothing thing. If they are truly optional then blkif.h should be updated > to say that.
They _are_ optional.
Jan
| |