Messages in this thread | | | Date | Mon, 13 Jan 2014 20:23:21 +0800 | From | Dave Young <> | Subject | Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable |
| |
> > > How about do not limit to only if (pgd) case, instead do something > > like below: set dump_to_dmesg as a module parameter > > X86_PTDUMP is not a module.
Hmm, I just see the module macros in the code, since it's a bool Kconfig I think the dump_pagetables.c need a cleanup, remove the #include <linux/module.h> and below lines: MODULE_LICENSE("GPL"); MODULE_AUTHOR("Arjan van de Ven <arjan@linux.intel.com>"); MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables");
> > And even though the idea to make the efi pagetable dumpable with a > kernel cmdline parameter doesn't sound all that bad, I'd like to hold > off on adding yet another efi= cmdline option and only do so until it is > really needed.
I think not necessary limit to efi=? Probably something like ptdump_dmesg=1|0
Thanks Dave
| |