Messages in this thread | | | Date | Tue, 14 Jan 2014 09:40:03 +0800 | From | Dave Young <> | Subject | Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable |
| |
On 01/13/14 at 06:48am, Arjan van de Ven wrote: > On 1/13/2014 4:23 AM, Dave Young wrote: > >> > >>>How about do not limit to only if (pgd) case, instead do something > >>>like below: set dump_to_dmesg as a module parameter > >> > >>X86_PTDUMP is not a module. > > > >Hmm, I just see the module macros in the code, since it's a bool Kconfig > >I think the dump_pagetables.c need a cleanup, > >remove the #include <linux/module.h> and below lines: > >MODULE_LICENSE("GPL"); > >MODULE_AUTHOR("Arjan van de Ven <arjan@linux.intel.com>"); > >MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables"); > > personally I consider it good form to always have this kind of information in .c files, > regardless of the KConfig side of thing...
I agree it's good to add these infomation, but they can be added in comment. IMHO it will be better in that way.
Thanks Dave
| |