lkml.org 
[lkml]   [2014]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] efi: Dump the EFI page table
On 01/13/14 at 04:00pm, Matt Fleming wrote:
> On Sat, 11 Jan, at 09:49:28PM, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > This is very useful for debugging issues with the recently added
> > pagetable switching code for EFI virtual mode.
> >
> > Signed-off-by: Borislav Petkov <bp@suse.de>
> > ---
> > arch/x86/platform/efi/efi.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> > index d62ec87a2b26..c34be4ce94c9 100644
> > --- a/arch/x86/platform/efi/efi.c
> > +++ b/arch/x86/platform/efi/efi.c
> > @@ -54,6 +54,7 @@
> > #include <asm/rtc.h>
> >
> > #define EFI_DEBUG
> > +#undef EFI_PGT_DBG
>
> Should this be a Kconfig option? Hacking source files to enable debug
> isn't the best idea. Plus you could make it depend on X86_PTDUMP.

I have same feeling, either a new Kconfig option or just print it while
ptdump_to_dmesg is true by default without extra Kconfig.

Thanks
Dave


\
 
 \ /
  Last update: 2014-01-14 03:01    [W:0.127 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site