lkml.org 
[lkml]   [2014]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/14] target/configfs: Expose protection device attributes
On 1/10/2014 9:00 AM, Nicholas A. Bellinger wrote:
> On Thu, 2014-01-09 at 13:01 +0200, Sagi Grimberg wrote:
>> On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:
>>> From: Nicholas Bellinger <nab@linux-iscsi.org>
>>>
>>> This patch adds support for exposing DIF protection device
>>> attributes via configfs. This includes:
>>>
>>> pi_prot_type: Protection Type (0, 1, 3 currently support)
>>> pi_prot_version: Protection Version (DIF v1 currently supported)
>>> pi_guard_type: Guard Type (1=DIF CRC, 2=IP CRC)
>>>
>>> Within se_dev_set_pi_prot_type() it also adds the se_subsystem_api
>>> device callbacks to setup per device protection information.
>> Suggestion, expose pi_prot_format and call transport->init_prot() there.
>> It is more explicit
>> and this routine should be called upon getting FORMAT_UNIT as well.
> <nod>, working on this next for FILEIO following your original example
> code.

I would suggest to keep user interface the same for all backstores.
Let me send you my latest WIP example for FILEIO that follows the
pi_prot_format notation and you can arrange it as you wish.

> Thanks Sagi!
>
> --nab
>
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html



\
 
 \ /
  Last update: 2014-01-12 13:21    [W:4.755 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site