Messages in this thread | | | Date | Mon, 13 Jan 2014 11:09:30 +0800 | From | Ren Qiaowei <> | Subject | Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information |
| |
On 01/13/2014 01:03 AM, Borislav Petkov wrote: > On Sun, Jan 12, 2014 at 08:49:21AM -0800, H. Peter Anvin wrote: >> I saw a previous version of the code that did that, and it really >> didn't work out well -- it ended up being more complex and slower. > > I suspected as much. > > But, we still probably should use the generic struct insn, insn_field, > etc and act on them in mpx.c instead of defining our own mpx_insn, > mpx_insn_field, X86_MODRM_MOD, etc in the header which are more or less > copied from insn.h, right? >
I tried to use generic structure and macro, but many members of generic struct insn are not used for MPX, and except this I have to add one member into this structure. So I define mpx specific struct insn.
And so I guess only struct insn_field and several macros like X86_XXX may use generic version. Anyway, I will try to use their generic version in next version for this patchset.
Thanks, Qiaowei
| |