Messages in this thread | | | Date | Sun, 12 Jan 2014 19:28:11 -0500 | From | Dave Jones <> | Subject | Re: [PATCH 1/1] lockdep: Kill held_lock->check and "int check" arg of __lock_acquire() |
| |
On Sun, Jan 12, 2014 at 06:45:54PM +0100, Oleg Nesterov wrote:
> diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > index 92b1bfc..13bd13d 100644 > --- a/include/linux/lockdep.h > +++ b/include/linux/lockdep.h > @@ -252,7 +252,6 @@ struct held_lock { > unsigned int trylock:1; /* 16 bits */ > > unsigned int read:2; /* see lock_acquire() comment */ > - unsigned int check:2; /* see lock_acquire() comment */ > unsigned int hardirqs_off:1; > unsigned int references:11; /* 32 bits */
The 'bits' comments seem to be crap, even before your patch.
Dave
| |