Messages in this thread Patch in this message | | | Date | Mon, 13 Jan 2014 09:30:14 +0900 | From | Simon Horman <> | Subject | Re: [PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI |
| |
On Fri, Jan 10, 2014 at 03:18:15PM +0000, Ben Dooks wrote: > If the kernel is built to support multi-arm configurmation with shmobile > support built in, then the drivers/sh is not built. This contains drivers > that are essential to devices support by that configuration, including the > PM runtime code in drivers/sh/pm_runtime.c (which implicitly enables the > bus clocks for all devices). > > If CONFIG_ARCH_SHMOBILE_MULTI then build the drivers/sh directory, > but ensure that bits that may conflict (drivers/sh/clk if the common > clock framework is not enabled) are built. > > The ARCH_SHMOBILE_MULTI was added by efacfce5f8a ("ARM: shmobile: Introduce > ARCH_SHMOBILE_MULTI") but this has only just recently been found due to > building device-tree only kernels. > > Cc: Linux Kernel list <linux-kernel@vger.kernel.org> > Cc: Linus SH list <linux-sh@vger.kernel.org> > Cc: Simon Horman <horms@verge.net.au> > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > drivers/Makefile | 1 + > drivers/sh/Makefile | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/Makefile b/drivers/Makefile > index 8e3b8b0..abc4744 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -118,6 +118,7 @@ obj-$(CONFIG_SGI_SN) += sn/ > obj-y += firmware/ > obj-$(CONFIG_CRYPTO) += crypto/ > obj-$(CONFIG_SUPERH) += sh/ > +obj-$(CONFIG_ARCH_SHMOBILE_MULTI) += sh/ > obj-$(CONFIG_ARCH_SHMOBILE_LEGACY) += sh/
Can't we just do the following?
obj-$(CONFIG_ARCH_SHMOBILE) += sh/
> ifndef CONFIG_ARCH_USES_GETTIMEOFFSET > obj-y += clocksource/ > diff --git a/drivers/sh/Makefile b/drivers/sh/Makefile > index fc67f56..86604a5 100644 > --- a/drivers/sh/Makefile > +++ b/drivers/sh/Makefile > @@ -3,7 +3,10 @@ > # > obj-y := intc/ > > +ifeq ($(CONFIG_COMMON_CLK),n) > obj-$(CONFIG_HAVE_CLK) += clk/ > +endif > + > obj-$(CONFIG_MAPLE) += maple/ > obj-$(CONFIG_SUPERHYWAY) += superhyway/ > > -- > 1.8.5.2 >
| |