Messages in this thread | | | Date | Sun, 12 Jan 2014 20:25:38 +0100 | From | Tomasz Figa <> | Subject | Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain |
| |
On 12.01.2014 20:20, Mark Brown wrote: > On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote: > >> static struct s3c64xx_pm_domain s3c64xx_pm_irom = { >> - .name = "IROM", >> .ena = S3C64XX_NORMALCFG_IROM_ON, >> .pd = { >> + .name = "domain_irom", > > This is nitpicking a bit but are you sure this is actually a > beautification of the name? It's mainly the domain_ bit, mostly since > I'd expect that if it's not obvious that this is a power domain the core > logging would be changed rather than tweaking the name of every power > domain user. >
Hmm, that's a really good point. A separate patch might change this and I could drop the "controversial" part of this patch ;).
Best regards, Tomasz
| |