Messages in this thread | | | Date | Sat, 11 Jan 2014 16:56:44 +0530 | Subject | Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c | From | Monam Agarwal <> |
| |
I took n as a flag to decide whether parent->in_left == node is true or not in the called function. Should I use some other name for the flag.
On Sat, Jan 11, 2014 at 4:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Sat, Jan 11, 2014 at 04:30:33PM +0530, Monam Agarwal wrote: >> The function interval_erase_color() in lustre/ldlm/interval_tree.c is >> too long and can be refactored. Most of the statements are same for if >> and else conditions. I am passing a new variable n based on which the >> differences are recognised. >> > > "n" stands for number, but what is the it the number of? > > regards, > dan carpenter >
| |