Messages in this thread | | | Date | Sat, 11 Jan 2014 22:35:59 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH] percpu-refcount: Add a WARN() for ref going negative |
| |
On Mon, Jan 06, 2014 at 01:13:26PM -0800, Kent Overstreet wrote: > AIO had a missing get, which led to an ioctx leak - after percpu_ref_kill() the > ref was 0 so percpu_ref_put() never saw it hit 0. > > This wasn't noticed at the time because it all happened completely silently, > this adds a WARN() which would've caught the aio bug. > > Signed-off-by: Kent Overstreet <kmo@daterainc.com> > Cc: Tejun Heo <tj@kernel.org>
Applied to percpu/for-3.14 w/ WARN_ONCE() instead WARN().
Thanks.
-- tejun
| |