Messages in this thread | | | Date | Sat, 11 Jan 2014 12:48:41 -0800 | From | Andrew Morton <> | Subject | Re: [percpu_counter] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:3537 check_flags() |
| |
On Sun, 12 Jan 2014 00:36:07 +0800 Ming Lei <tom.leiming@gmail.com> wrote:
> > > > [ 8.093354] ------------[ cut here ]------------ > > [ 8.095469] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:3537 check_flags+0x77/0x1ba() > > [ 8.095469] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled) > > The warning is caused by the added raw_local_irq_save(), which should > have been local_irq_save(flags). Actually, it is a false positive. > > Andrew, considered that your approach may be more efficient than this > one since preempt_disable()/preempt_enable() can be removed too. > > So could you prepare one patch for fixing the problem? Or if you are busy, I'd > like to do it.
Yes, please send a fresh patch.
| |