Messages in this thread Patch in this message | | | From | Monam Agarwal <> | Subject | [PATCH v2] Staging: lustre: Use of fls to find last set bit | Date | Sun, 12 Jan 2014 01:02:43 +0530 |
| |
This introduces fls in lustre/ldlm/ldlm_extent.c to find the last set bit.
It also fixes the following checkpatch.pl warning in lustre/ldlm/ldlm_extent.c WARNING: space prohibited before semicolon.
The patch also fixes the following checkpatch.pl error in lustre/ldlm/ldlm_extent.c ERROR: trailing statements should be on next line
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> --- Changes since v1: *Incorrect commit message *Use of fls function
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c b/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c index ac5d66a..e6fe2cb 100644 --- a/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_extent.c @@ -150,10 +150,12 @@ struct ldlm_interval *ldlm_interval_detach(struct ldlm_lock *l) static inline int lock_mode_to_index(ldlm_mode_t mode) { int index; + int len; LASSERT(mode != 0); LASSERT(IS_PO2(mode)); - for (index = -1; mode; index++, mode >>= 1) ; + len = fls(mode); + index = len-1; LASSERT(index < LCK_MODE_NUM); return index; } -- 1.7.9.5
| |