Messages in this thread | | | From | "Brown, Aaron F" <> | Subject | RE: [PATCH] e1000: avoid potential deadlock in e1000_do_[read|write]_eeprom() | Date | Sat, 11 Jan 2014 03:35:25 +0000 |
| |
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] > On Behalf Of Alexey Khoroshilov > Sent: Friday, December 20, 2013 2:25 PM > To: Kirsher, Jeffrey T > Cc: Alexey Khoroshilov; Brandeburg, Jesse; Allan, Bruce W; Wyborny, > Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck, Alexander H; Ronciak, > John; e1000-devel@lists.sourceforge.net; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; ldv-project@linuxtesting.org > Subject: [PATCH] e1000: avoid potential deadlock in > e1000_do_[read|write]_eeprom() > > If eeprom->word_size is zero, e1000_do_[read|write]_eeprom() invoke > e1000_init_eeprom_params() to reinit eeprom params. > That is not a good idea since e1000_init_eeprom_params() calls > e1000_read_eeprom() if eeprom->type is e1000_eeprom_spi. > That means a deadlock on e1000_eeprom_lock. > > At the same time it is unclear if the reinit is needed at all. > e1000_init_eeprom_params() is called from probe, so it should succeed > before any activities of the module start. > > The patch suggests to remove the try to reinit eeprom params. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com> Tested by: Aaron Brown <aaron.f.brown@intel.com>
> --- > drivers/net/ethernet/intel/e1000/e1000_hw.c | 8 -------- > 1 file changed, 8 deletions(-)
| |