Messages in this thread Patch in this message | | | From | "Brown, Aaron F" <> | Subject | RE: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare | Date | Sat, 11 Jan 2014 03:30:25 +0000 |
| |
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] > On Behalf Of Ding Tianhong > Sent: Friday, December 27, 2013 10:17 PM > To: Kirsher, Jeffrey T; Brandeburg, Jesse; Wyborny, Carolyn; Skidmore, > Donald C; David S. Miller; Netdev; linux-kernel@vger.kernel.org > Subject: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr > compare > > Use possibly more efficient ether_addr_equal to instead of memcmp. > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Carolyn Wyborny <carolyn.wyborny@intel.com> > Cc: Don Skidmore <donald.c.skidmore@intel.com> > Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com> Tested by: Aaron Brown <aaron.f.brown@intel.com>
> --- > drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c > b/drivers/net/ethernet/intel/igbvf/netdev.c > index 04bf22e..675435f 100644 > --- a/drivers/net/ethernet/intel/igbvf/netdev.c > +++ b/drivers/net/ethernet/intel/igbvf/netdev.c > @@ -1745,7 +1745,7 @@ static int igbvf_set_mac(struct net_device *netdev, > void *p) > > hw->mac.ops.rar_set(hw, hw->mac.addr, 0); > > - if (memcmp(addr->sa_data, hw->mac.addr, 6)) > + if (!ether_addr_equal(addr->sa_data, hw->mac.addr)) > return -EADDRNOTAVAIL; > > memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); > -- > 1.8.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |