Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v2 0/9] cpuidle: rework device state count handling | Date | Sat, 11 Jan 2014 01:37:29 +0100 |
| |
On Friday, December 20, 2013 07:47:22 PM Bartlomiej Zolnierkiewicz wrote: > Hi, > > Some cpuidle drivers assume that cpuidle core will handle cases where > device->state_count is smaller than driver->state_count, unfortunately > currently this is untrue (device->state_count is used only for handling > cpuidle state sysfs entries and driver->state_count is used for all > other cases) and will not be fixed in the future as device->state_count > is planned to be removed [1]. > > This patchset fixes such drivers (ARM EXYNOS cpuidle driver and ACPI > cpuidle driver), removes superflous device->state_count initialization > from drivers for which device->state_count equals driver->state_count > (POWERPC pseries cpuidle driver and intel_idle driver) and finally > removes state_count field from struct cpuidle_device. > > Additionaly (while at it) this patchset fixes C1E promotion disable > quirk handling (in intel_idle driver) and converts cpuidle drivers code > to use the common cpuidle_[un]register() routines (in POWERPC pseries > cpuidle driver and intel_idle driver). > > [1] http://permalink.gmane.org/gmane.linux.power-management.general/36908 > > Reference to v1: > http://comments.gmane.org/gmane.linux.power-management.general/37390 > > Changes since v1: > - synced patch series with next-20131220 > - added ACKs from Daniel Lezcano
This series breaks boot on one of my test machines with intel_idle, so I'm not sure how well it has been tested.
I've dropped it entirely for now. If I have the time, I will try to identify the root cause of the failure, but that may not happen before the merge window. Sorry about that.
Thanks!
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |