Messages in this thread | | | Date | Fri, 10 Jan 2014 15:29:04 +0800 | From | "Li, ZhenHua" <> | Subject | Re: [PATCH 1/1] x86/iommu: use bit structures for context_entry |
| |
I have not seen such a bug yet . but obviously a '=' should be used when you want to set a value.
for example, if x != 0, x=10 and x|=10 will cause different result.
ZhenHua
On 01/07/2014 10:41 PM, Joerg Roedel wrote: > On Fri, Dec 20, 2013 at 04:45:01PM +0800, Li, Zhen-Hua wrote: >> There is a structure named context_entry used by intel iommu, and there >> are some bit operations on it. Use bit structure may make these operations >> easy. >> Also the function context_set_address_root may cause problem because it uses >> |= operation, not set the new value. And this patch can fix it. > > What is the problem you are trying to fix here? Is it an actual bug? > > > Joerg > >
| |