This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Wed May 1 00:46:44 2024 Envelope-to: j@jasper.es Delivery-date: Fri, 10 Jan 2014 23:08:24 +0100 Received: from localhost ([127.0.0.1] helo=squeeze.vs19.net) by squeeze.vs19.net with esmtp (Exim 4.80) (envelope-from ) id 1W1kFb-0000aY-LZ for j@jasper.es; Fri, 10 Jan 2014 23:08:23 +0100 Original-Recipient: rfc822;jasper@telfort.nl Received: from pop3.telfort.nl [213.75.3.52] by squeeze.vs19.net with POP3 (fetchmail-6.3.21) for (single-drop); Fri, 10 Jan 2014 23:08:23 +0100 (CET) Received: from cpxmta-msg01.kpnxchange.com (10.94.114.22) by cpxmbs-msg01.support.local (8.6.060.31) id 52B0AB3D010D7852 for jasper@telfort.nl; Fri, 10 Jan 2014 23:02:31 +0100 Received: from cpsmtpb-ews01.kpnxchange.com (213.75.39.4) by cpxmta-msg01.kpnxchange.com (8.6.060.14) id 5279B8F4078976F3 for jasper@telfort.nl; Fri, 10 Jan 2014 23:02:31 +0100 Received: from cpsps-ews15.kpnxchange.com ([10.94.84.182]) by cpsmtpb-ews01.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Fri, 10 Jan 2014 23:02:31 +0100 Received: from vger.kernel.org ([209.132.180.67]) by cpsps-ews15.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Fri, 10 Jan 2014 23:02:31 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758146AbaAJWC0 (ORCPT ); Fri, 10 Jan 2014 17:02:26 -0500 Received: from mail.windriver.com ([147.11.1.11]:39183 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbaAJWCY (ORCPT ); Fri, 10 Jan 2014 17:02:24 -0500 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.5) with ESMTP id s0AM2H6R012291 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 10 Jan 2014 14:02:17 -0800 (PST) Received: from yow-asskicker.wrs.com (128.224.146.66) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.2.347.0; Fri, 10 Jan 2014 14:02:17 -0800 From: Paul Gortmaker To: Richard Henderson , Ivan Kokshaysky Cc: , , Paul Gortmaker Subject: [PATCH] alpha: don't use module_init for non-modular core code Date: Fri, 10 Jan 2014 17:02:02 -0500 Message-Id: <1389391322-29873-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 1.8.5.2 Mime-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-OriginalArrivalTime: 10 Jan 2014 22:02:31.0479 (UTC) FILETIME=[A8D54C70:01CF0E4F] X-RcptDomain: telfort.nl The srm console is always built in. It will never be modular, so using module_init as an alias for __initcall is rather misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Direct use of __initcall is discouraged, vs prioritized ones. Use of device_initcall is consistent with what __initcall maps onto, and hence does not change the init order, making the impact of this change zero. Should someone with real hardware for boot testing want to change it later to arch_initcall or console_initcall, they can do that at a later date. Signed-off-by: Paul Gortmaker diff --git a/arch/alpha/kernel/srmcons.c b/arch/alpha/kernel/srmcons.c index 6f01d9ad7b81..72b59511e59a 100644 --- a/arch/alpha/kernel/srmcons.c +++ b/arch/alpha/kernel/srmcons.c @@ -237,8 +237,7 @@ srmcons_init(void) return -ENODEV; } - -module_init(srmcons_init); +device_initcall(srmcons_init); /* -- 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/