lkml.org 
[lkml]   [2014]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86, e820 disable ACPI Memory Hotplug if memory mapping is specified by user [v2]
On Fri, Jan 10, 2014 at 02:04:58PM -0500, Prarit Bhargava wrote:

> kdump uses memmap=exactmap and mem=X values

Minor nit. Kdump only uses memmap=exactmap and not mem=X. mem=X is there
for debugging. So lets fix the changelog.

[..]
> static int __init parse_memmap_opt(char *str)
> {
> + int ret;
> +
> while (str) {
> char *k = strchr(str, ',');
>
> if (k)
> *k++ = 0;
>
> - parse_memmap_one(str);
> + ret = parse_memmap_one(str);
> + if (!ret)
> + set_acpi_no_memhotplug();

We want to call this only in case of memmap=exactmap and not other memmap=
options. So I think instead of here, call it inside parse_memmap_one()
where exactmap check is done.

if (!strncmp(p, "exactmap", 8)) {
set_acpi_no_memhotplug();
}

Thanks
Vivek


\
 
 \ /
  Last update: 2014-01-10 22:41    [W:0.057 / U:2.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site