Messages in this thread | | | Date | Fri, 10 Jan 2014 15:06:52 +0800 | From | Jason Wang <> | Subject | Re: [PATCH net 1/2] macvlan: forbid L2 fowarding offload for macvtap |
| |
On 01/10/2014 05:39 AM, Stephen Hemminger wrote: > On Thu, 09 Jan 2014 16:55:07 +0800 > Jason Wang <jasowang@redhat.com> wrote: > >> What if use do want a qdisc and want to change the its queue length for >> tun/macvlan? And the the name tx_queue_length is misleading. For tun it >> may make sense since it was used in transmission path. For macvtap it >> was not. So maybe what we need is just a new ioctl for both tun/macvtap >> and a new feature flag. If user create the device with new feature flag, >> the socket receive queue length could be changed by ioctl instead of >> dev->tx_queue_length. If not, the old behaviour could be kept. > The overloading of tx_queue_len in macvtap was the original design mistake. > Can't this just be undone and expose rx_queue_len as sysfs attribute?
That works. But we current allow user to change the socket sndbuf through TUNSNDBUF. Maybe we need a similar one for receive.
| |