Messages in this thread | | | Date | Mon, 9 Sep 2013 09:12:30 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 1/2] input: ti_am335x_tsc: Enable shared IRQ for TSC |
| |
On Sun, Sep 08, 2013 at 12:29:26PM +0100, Jonathan Cameron wrote: > On 09/01/13 12:17, Zubair Lutfullah wrote: > > Enable shared IRQ to allow ADC to share IRQ line from > > parent MFD core. Only FIFO0 IRQs are for TSC and handled > > on the TSC side. > > > > Step mask would be updated from cached variable only previously. > > In rare cases when both TSC and ADC are used, the cached > > variable gets mixed up. > > The step mask is written with the required mask every time. > > > > Rachna Patil (TI) laid ground work for shared IRQ. > > > > Signed-off-by: Zubair Lutfullah <zubair.lutfullah@gmail.com> > Whilst I would have prefered an mfd under these drivers and elegant handling > of the interrupts, I guess if this works it is at least not terribly invasive. > > However, this does need an Ack from Dmitry before I can take it (or for > Dmitry to take it himself?)
I completely agree with Jonathan, more elegant handling would be nice but current one will do for now.
Since most of the work on the driver is going through IIO tree I think it would make sense for this patch to go through it as well.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
-- Dmitry
| |