Messages in this thread | | | Date | Sun, 8 Sep 2013 17:26:02 +0300 | From | Gleb Natapov <> | Subject | Re: [PATCH v2 01/15] KVM: MMU: fix the count of spte number |
| |
On Sun, Sep 08, 2013 at 10:24:05PM +0800, Xiao Guangrong wrote: > > On Sep 8, 2013, at 10:01 PM, Gleb Natapov <gleb@redhat.com> wrote: > > > On Sun, Sep 08, 2013 at 09:55:04PM +0800, Xiao Guangrong wrote: > >> > >> On Sep 8, 2013, at 8:19 PM, Gleb Natapov <gleb@redhat.com> wrote: > >> > >>> On Thu, Sep 05, 2013 at 06:29:04PM +0800, Xiao Guangrong wrote: > >>>> If the desc is the last one and it is full, its sptes is not counted > >>>> > >>> Hmm, if desc is not full but it is not the last one all sptes after the > >>> desc are not counted too. > >> > >> But the desc must be the last one if it's not full since we always add > >> new entry or delete entry from the last desc. > >> > > Why do we alway delete entries from last desc? We delete them from the > > desc we found them in. Current code does not try to move entries between > > descs, only inside a desc. > > Oh, yes. Sorry, my memory is wrong… :( > > So, currently there has some gaps in desc and it wastes memory. Can not fix > them with simple change and i think it is not worthy to fix them separately since > after my new algorithm, these should all be fixed… so how about just drop this > fix? > Yes, if we are going to change algorithm anyway no need to spend time fixing what we have now.
-- Gleb. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |