Messages in this thread | | | From | Linn Crosetto <> | Subject | [PATCH 0/3] x86/mm: fix early_memremap() sparse warnings | Date | Fri, 6 Sep 2013 12:06:54 -0600 |
| |
This set of patches cleans up some sparse warnings generated by callers of early_memremap().
early_memremap() was created as an interface to to map normal memory (commit 1494177), in contrast to early_ioremap() for IO mappings. Later on, early_memremap() was annotated with __iomem (commit 1d6cf1f) which generates sparse warnings for callers using pointers not declared with __iomem. Callers of early_memremap() were expected to use early_iounmap() to remove the mapping, which generates more sparse warnings as the argument to early_iounmap() is also annotated with __iomem.
To clean this up, remove __iomem from early_memremap() and create early_memunmap() to be used for removing normal memory mappings.
Removes the following warnings:
arch/x86/kernel/setup.c:353:19: warning: incorrect type in assignment (different address spaces) arch/x86/kernel/setup.c:355:31: warning: incorrect type in argument 1 (different address spaces) arch/x86/kernel/setup.c:437:22: warning: incorrect type in assignment (different address spaces) arch/x86/kernel/setup.c:441:31: warning: incorrect type in argument 1 (different address spaces) arch/x86/kernel/setup.c:465:22: warning: incorrect type in assignment (different address spaces) arch/x86/kernel/setup.c:470:31: warning: incorrect type in argument 1 (different address spaces) arch/x86/kernel/setup.c:488:22: warning: incorrect type in assignment (different address spaces) arch/x86/kernel/setup.c:491:31: warning: incorrect type in argument 1 (different address spaces) arch/x86/kernel/e820.c:667:15: warning: incorrect type in assignment (different address spaces) arch/x86/kernel/e820.c:672:23: warning: incorrect type in argument 1 (different address spaces)
Linn Crosetto (3): x86/mm: fix sparse warnings from early_memremap() x86: fix sparse warning in parse_e820_ext() x86: fix early_iounmap() sparse warnings in setup.c
arch/x86/include/asm/io.h | 4 ++-- arch/x86/kernel/e820.c | 2 +- arch/x86/kernel/setup.c | 8 ++++---- arch/x86/mm/ioremap.c | 9 +++++++-- 4 files changed, 14 insertions(+), 9 deletions(-)
-- 1.7.11.3
| |