Messages in this thread | | | Date | Thu, 5 Sep 2013 21:57:22 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH RESEND v3 1/7] Intel MIC Host Driver for X100 family. |
| |
On Thu, Sep 05, 2013 at 04:41:31PM -0700, Sudeep Dutt wrote: > drivers/misc/mic/common/mic_device.h | 37 +++ > drivers/misc/mic/host/mic_device.h | 109 +++++++++
Two different files, with the same name? You are asking for trouble in the future, getting them confused :)
Please try to pick a unique name, especially when you later do things like:
> +#include "../common/mic_device.h" > +#include "mic_device.h"
Which just looks odd.
Again, not a big deal, follow-on patch can fix this.
thanks,
greg k-h
| |