lkml.org 
[lkml]   [2013]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RESEND v3 1/7] Intel MIC Host Driver for X100 family.
    On Thu, Sep 05, 2013 at 04:41:31PM -0700, Sudeep Dutt wrote:
    > drivers/misc/mic/common/mic_device.h | 37 +++
    > drivers/misc/mic/host/mic_device.h | 109 +++++++++

    Two different files, with the same name? You are asking for trouble in
    the future, getting them confused :)

    Please try to pick a unique name, especially when you later do things
    like:

    > +#include "../common/mic_device.h"
    > +#include "mic_device.h"

    Which just looks odd.

    Again, not a big deal, follow-on patch can fix this.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2013-09-06 07:21    [W:5.852 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site