| Date | Thu, 5 Sep 2013 15:52:17 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC][PATCH 14/18 v2] ftrace/lockdep: Have the RCU lockdep splat show what function triggered |
| |
On Thu, 5 Sep 2013 21:18:39 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> On Sat, Aug 31, 2013 at 01:11:31AM -0400, Steven Rostedt wrote: > > +void print_ftrace_rcu_func(int cpu) > > +{ > > + unsigned long ip = per_cpu(ftrace_rcu_func, cpu); > > + > > + if (ip) > > + printk("ftrace_rcu_func: %pS\n", > > + (void *)per_cpu(ftrace_rcu_func, cpu)); > > +} > > That's missing { }.
Hmm, that's an interesting point. Why the { } because I break up the printk for the 80 character limit?
Although, I'm still not convinced that it needs { }, as it looks to me that it flows nicely without it. I can't find a place in CodingStyle that says { } are needed here.
-- Steve
|