Messages in this thread | | | Date | Thu, 05 Sep 2013 14:25:32 -0400 | From | John David Anglin <> | Subject | Re: [PATCH] parisc: Export flush_cache_page() (needed by lustre) |
| |
On 9/5/2013 12:01 PM, James Bottomley wrote: > On Thu, 2013-09-05 at 11:33 +0200, Geert Uytterhoeven wrote: >> ERROR: "flush_cache_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> --- >> arch/parisc/kernel/cache.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c >> index c035673..b521c0a 100644 >> --- a/arch/parisc/kernel/cache.c >> +++ b/arch/parisc/kernel/cache.c >> @@ -602,6 +602,7 @@ flush_cache_page(struct vm_area_struct *vma, unsigned long vmaddr, unsigned long >> __flush_cache_page(vma, vmaddr, PFN_PHYS(pfn)); >> } >> } >> +EXPORT_SYMBOL_GPL(flush_cache_page); > This is an internal API: no architecture exports this. Whoever is > trying to use it needs to use the correct API, so this is the wrong > patch. > There is a declaration for it in arch/parisc/include/asm/cacheflush.h. There are a bunch of callers in mm. The interface in documented in Documentation/cachetlb.txt. We currently use it in copy_to_user_page and copy_from_user_page.
Dave
-- John David Anglin dave.anglin@bell.net
| |