Messages in this thread Patch in this message | | | From | Steven Whitehouse <> | Subject | [PATCH 4/6] GFS2: Remove unnecessary memory barrier | Date | Thu, 5 Sep 2013 10:02:10 +0100 |
| |
From: Bob Peterson <rpeterso@redhat.com>
Function test_and_clear_bit implies a memory barrier, so subsequent memory barriers are unnecessary.
Signed-off-by: Bob Peterson <rpeterso@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index ce7078d..722329c 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -1411,7 +1411,6 @@ __acquires(&lru_lock) if (demote_ok(gl)) handle_callback(gl, LM_ST_UNLOCKED, 0, false); WARN_ON(!test_and_clear_bit(GLF_LOCK, &gl->gl_flags)); - smp_mb__after_clear_bit(); if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0) gfs2_glock_put_nolock(gl); spin_unlock(&gl->gl_spin); -- 1.7.4
| |