lkml.org 
[lkml]   [2013]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 056/104] libceph: unregister request in __map_request failed and nofail == false
    Date
    3.5.7.22 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: majianpeng <majianpeng@gmail.com>

    commit 73d9f7eef3d98c3920e144797cc1894c6b005a1e upstream.

    For nofail == false request, if __map_request failed, the caller does
    cleanup work, like releasing the relative pages. It doesn't make any sense
    to retry this request.

    Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
    Reviewed-by: Sage Weil <sage@inktank.com>
    [ luis: backported to 3.5: adjusted context ]
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    net/ceph/osd_client.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
    index f181972..a90c575 100644
    --- a/net/ceph/osd_client.c
    +++ b/net/ceph/osd_client.c
    @@ -1745,6 +1745,8 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc,
    dout("osdc_start_request failed map, "
    " will retry %lld\n", req->r_tid);
    rc = 0;
    + } else {
    + __unregister_request(osdc, req);
    }
    goto out_unlock;
    }
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-09-30 12:41    [W:4.022 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site