Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH -tip ] [BUGFIX] perf probe: Fix to find line information for probe list | Date | Mon, 30 Sep 2013 14:08:07 +0900 |
| |
Hi Masami,
Just a nitpick.
On Fri, 27 Sep 2013 15:57:07 +0900, Masami Hiramatsu wrote: > /** > + * die_find_inlinefunc_next - Search an inlined function at given address > + * @cu_die: a CU DIE which including @addr
s/cu_die/sp_die/
And it doesn't look like a CU DIE, anyway.
Thanks, Namhyung
> + * @addr: target address > + * @die_mem: a buffer for result DIE > + * > + * Search an inlined function DIE which includes @addr. Stores the > + * DIE to @die_mem and returns it if found. Returns NULL if failed. > + * Even if several inlined functions are expanded recursively, this > + * doesn't trace it down, and returns the topmost one. > + */ > +Dwarf_Die *die_find_inlinefunc_next(Dwarf_Die *sp_die, Dwarf_Addr addr, > + Dwarf_Die *die_mem) > +{ > + return die_find_child(sp_die, __die_find_inline_cb, &addr, die_mem); > +}
| |